Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: BUILDING.md - python3-distutils dependency #33174

Closed
wants to merge 1 commit into from
Closed

docs: BUILDING.md - python3-distutils dependency #33174

wants to merge 1 commit into from

Conversation

osher
Copy link
Contributor

@osher osher commented Apr 30, 2020

Ran into #30189, solved by this comment:
#30189 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Apr 30, 2020
@osher
Copy link
Contributor Author

osher commented May 3, 2020

really? 😕
I changed a MD file, and the windows build fails...

How do we handle flaky builds here?

@BridgeAR
Copy link
Member

BridgeAR commented May 3, 2020

@nodejs/documentation @nodejs/python PTAL

Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure is a flaky test, nothing to worry about.

@addaleax
Copy link
Member

addaleax commented May 7, 2020

Landed in d6913dc

@addaleax addaleax closed this May 7, 2020
addaleax pushed a commit that referenced this pull request May 7, 2020
Ran into #30189, solved by this comment:
#30189 (comment)

Refs: #30189
PR-URL: #33174
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
codebytere pushed a commit that referenced this pull request May 11, 2020
Ran into #30189, solved by this comment:
#30189 (comment)

Refs: #30189
PR-URL: #33174
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
@codebytere codebytere mentioned this pull request May 18, 2020
codebytere pushed a commit that referenced this pull request Jun 7, 2020
Ran into #30189, solved by this comment:
#30189 (comment)

Refs: #30189
PR-URL: #33174
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
@codebytere codebytere mentioned this pull request Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants